bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio by aeros · Pull Request #16552 · python/cpython

@aeros

@aeros

aeros

aeros

vstinner

asvetlov

@aeros aeros changed the title bpo-38356: Fix ThreadedChildWatcher thread leak bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio

Oct 23, 2019

@aeros aeros changed the title bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio bpo-38356: Fix ThreadedChildWatcher thread leak for test_asyncio

Oct 24, 2019

@aeros aeros changed the title bpo-38356: Fix ThreadedChildWatcher thread leak for test_asyncio bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio

Oct 29, 2019

asvetlov

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 12, 2020
…onGH-16552)

Motivation for this PR (comment from @vstinner in bpo issue):
```
Warning seen o AMD64 Ubuntu Shared 3.x buildbot:
https://buildbot.python.org/all/GH-/builders/141/builds/2593

test_devnull_output (test.test_a=syncio.test_subprocess.SubprocessThreadedWatcherTests) ...
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
```
The following implementation details for the new method are TBD:

1) Public vs private

2) Inclusion in `close()`

3) Name

4) Coroutine vs subroutine method

5) *timeout* parameter

If it's a private method, 3, 4, and 5 are significantly less important.

I started with the most minimal implementation that fixes the dangling threads without modifying the regression tests, which I think is particularly important. I typically try to avoid directly modifying existing tests as much as possible unless it's necessary to do so. However, I am open to changing any part of this.

https://bugs.python.org/issue38356
(cherry picked from commit 0ca7cc7)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>

miss-islington added a commit that referenced this pull request

Jan 12, 2020
…6552)

Motivation for this PR (comment from @vstinner in bpo issue):
```
Warning seen o AMD64 Ubuntu Shared 3.x buildbot:
https://buildbot.python.org/all/GH-/builders/141/builds/2593

test_devnull_output (test.test_a=syncio.test_subprocess.SubprocessThreadedWatcherTests) ...
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
```
The following implementation details for the new method are TBD:

1) Public vs private

2) Inclusion in `close()`

3) Name

4) Coroutine vs subroutine method

5) *timeout* parameter

If it's a private method, 3, 4, and 5 are significantly less important.

I started with the most minimal implementation that fixes the dangling threads without modifying the regression tests, which I think is particularly important. I typically try to avoid directly modifying existing tests as much as possible unless it's necessary to do so. However, I am open to changing any part of this.

https://bugs.python.org/issue38356
(cherry picked from commit 0ca7cc7)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request

Jan 31, 2020
…onGH-16552)

Motivation for this PR (comment from @vstinner in bpo issue):
```
Warning seen o AMD64 Ubuntu Shared 3.x buildbot:
https://buildbot.python.org/all/#/builders/141/builds/2593

test_devnull_output (test.test_a=syncio.test_subprocess.SubprocessThreadedWatcherTests) ...
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
```
The following implementation details for the new method are TBD:

1) Public vs private

2) Inclusion in `close()`

3) Name

4) Coroutine vs subroutine method

5) *timeout* parameter

If it's a private method, 3, 4, and 5 are significantly less important.

I started with the most minimal implementation that fixes the dangling threads without modifying the regression tests, which I think is particularly important. I typically try to avoid directly modifying existing tests as much as possible unless it's necessary to do so. However, I am open to changing any part of this.


https://bugs.python.org/issue38356