[3.7] bpo-38379: don't claim objects are collected when they aren't (GH-16658) by pablogsal · Pull Request #16685

[3.7] bpo-38379: don't claim objects are collected when they aren't (GH-16658) by pablogsal · Pull Request #16685 · python/cpython

Conversation

pablogsal changed the title ~~[3.7] bpo-38379: don't claim objects are collected when they aren't …~~ [3.7] bpo-38379: don't claim objects are collected when they aren't (GH-16658)

Oct 9, 2019

I'm fixing the errors from the merge conflicts

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - thank you again 😃

…ythonGH-16658)

* bpo-38379:  when a finalizer resurrects an object,
nothing is actually collected in this run of gc.
Change the stats to relect that truth..
(cherry picked from commit ecbf35f)

Co-authored-by: Tim Peters <tim.peters@gmail.com>

Looks like the for loop opener needs to be changed for 3.7 ☹️ ... and looks like you already did that!

Looks like the for loop opener needs to be changed for 3.7 frowning_face ... and looks like you already did that!

Yeah, for some reason I did not push correctly my latest fixes for the merge conflicts. Apologies for the confusion!

@pablogsal: Status check is done, and it's a success ✅ .