gh-69708: IDLE "Save As" warnings by ZackerySpytz · Pull Request #17051 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ZackerySpytz

Copy link Copy Markdown

Contributor

@ZackerySpytz ZackerySpytz commented

Nov 5, 2019

edited by bedevere-bot

Loading

Give a warning when attempting to save a file that shadows a module
in the standard library.

https://bugs.python.org/issue25522

Give a warning when attempting to save a file that shadows a module
in the standard library.

@hauntsaninja hauntsaninja changed the title bpo-25522: IDLE "Save As" warnings gh-69708: IDLE "Save As" warnings

Jan 7, 2023

@serhiy-storchaka

Copy link Copy Markdown

Member

  1. The warning should only be emitted if the file extension matches Python source extensions. IDLE allows to edit other text files, they do not conflict with modules.
  2. The warning should only be emitted for saving a new file. If file already exists, then the user already saved it and asked the question.
  3. There should be more reliable way to determine if the name conflicts with an existing module. For example using importlib.util.find_spec().

@github-actions

Copy link Copy Markdown

github-actions bot commented

Apr 7, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale

Stale PR or inactive for long period of time.

label

Apr 7, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees

No one assigned

Labels

awaiting review stale

Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZackerySpytz @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti @bedevere-bot