bpo-25430: improve performance of IPNetwork.__contains__ by gescheit · Pull Request #1785 · python/cpython

@gescheit

@gescheit

make a compare in bit-operation manner

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@mention-bot

@pitrou

@pitrou pitrou changed the title bpo-25430: performance improvements bpo-25430: improve performance of IPNetwork.__contains__

May 25, 2017

@BoboTiG

Thanks @gescheit, changes looks good to me!
I think adding a NEWs entry would be good too, don't you?

@asvetlov

What is performance boost?

@BoboTiG

@asvetlov you can find numbers in the description of the BPO.

@asvetlov

asvetlov

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS entry is requered

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tirkarthi

@blurb-it

Cant2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.