[3.6] bpo-38576: Disallow control characters in hostnames in http.client (GH-18995) by miss-islington · Pull Request #19002

[3.6] bpo-38576: Disallow control characters in hostnames in http.client (GH-18995) by miss-islington · Pull Request #19002 · python/cpython

Merged

ned-deily merged 1 commit intopython:3.6from

miss-islington:backport-9165add-3.6

Mar 14, 2020

Merged

[3.6] bpo-38576: Disallow control characters in hostnames in http.client (GH-18995)#19002
ned-deily merged 1 commit intopython:3.6from
miss-islington:backport-9165add-3.6

Conversation

Copy link Copy Markdown

Contributor

miss-islington commented
Mar 14, 2020
•

edited by bedevere-bot

Loading

Add host validation for control characters for more CVE-2019-18348 protection.
(cherry picked from commit 9165add)

Co-authored-by: Ashwin Ramaswami aramaswamis@gmail.com

https://bugs.python.org/issue38576

bpo-38576: Disallow control characters in hostnames in http.client (p…

1e24df6

…ythonGH-18995)

Add host validation for control characters for more CVE-2019-18348 protection.
(cherry picked from commit 9165add)

Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>

the-knights-who-say-ni added the CLA signed label

Mar 14, 2020

bedevere-bot mentioned this pull request

Mar 14, 2020

bpo-38576: Disallow control characters in hostnames in http.client #18995

Merged

bedevere-bot added type-bug

An unexpected behavior, bug, or error

type-security

A security issue

awaiting review labels

Mar 14, 2020

gpshead assigned ned-deily

Mar 14, 2020

gpshead approved these changes Mar 14, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Mar 14, 2020

Copy link Copy Markdown

Contributor Author

miss-islington commented
Mar 14, 2020

@epicfaace and @gpshead: Status check is done, and it's a success ✅ .

Copy link Copy Markdown

Contributor Author

miss-islington commented
Mar 14, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

Copy link Copy Markdown

Contributor Author

miss-islington commented
Mar 14, 2020

@epicfaace and @gpshead: Status check is done, and it's a success ✅ .

Copy link Copy Markdown

Contributor Author

miss-islington commented
Mar 14, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

ned-deily merged commit 83fc701 into python:3.6