bpo-25324: Move the description of tokenize tokens to token.rst. by serhiy-storchaka · Pull Request #1911 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@serhiy-storchaka

Copy link Copy Markdown

Member

Also tweaks the formatting.

@serhiy-storchaka serhiy-storchaka added the docs

Documentation in the Doc dir

label

Jun 1, 2017

@mention-bot

Copy link Copy Markdown

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @benjaminp and @vadmium to be potential reviewers.

Comment thread

Doc/library/token.rst Outdated

Added :data:`COMMENT`, :data:`NL` and :data:`ENCODING` to bring
the tokens in the C code in line with the tokens needed in
:mod:`tokenize` module. These tokens aren't used by the C tokenizer. No newline at end of file
Following token type values aren't used by the C tokenizer but are needed for
Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the in front: The following token type values . . .

@serhiy-storchaka serhiy-storchaka merged commit 5cefb6c into python:master

Jun 6, 2017

@serhiy-storchaka serhiy-storchaka deleted the token-docs branch

June 6, 2017 15:43

@serhiy-storchaka

Copy link Copy Markdown

Member Author

Thank you for your review @vadmium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadmium vadmium vadmium left review comments

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @mention-bot @vadmium @the-knights-who-say-ni