bpo-40185: Refactor typing.NamedTuple by serhiy-storchaka · Pull Request #19371 · python/cpython

@serhiy-storchaka

@serhiy-storchaka

ilevkivskyi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, because people sometimes erroneously percept NamedTuple as a "normal" class. I would however double-check with Guido if he is also OK with this.

pass
with self.assertRaises(TypeError):
class X(NamedTuple, A):
x: int

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bad merge/rebase, you already added this test in a different PR.

@serhiy-storchaka

@serhiy-storchaka

gvanrossum

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A work of art!

@serhiy-storchaka

juliusgeo added a commit to juliusgeo/cpython that referenced this pull request

Mar 4, 2022

@juliusgeo