[3.9] bpo-36290: Fix keyword collision handling in AST node constructors (GH-12382) by miss-islington · Pull Request #20365 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.5k
Merged
miss-islington merged 1 commit intopython:3.9from
May 24, 2020Merged
Conversation
Copy link Copy Markdown
Contributor
(cherry picked from commit c73914a)
Co-authored-by: Rémi Lapeyre remi.lapeyre@lenstra.fr
…ythonGH-12382) (cherry picked from commit c73914a) Co-authored-by: Rémi Lapeyre <remi.lapeyre@lenstra.fr>
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
mentioned this pull request
bedevere-bot
added
the
awaiting review
label
pablogsal approved these changes May 24, 2020
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
Copy link Copy Markdown
Member
It's maybe a bit too late, but there's a minor typo in the title here, in #20366 and the master commit message. (keytword -> keyword)
Copy link Copy Markdown
Contributor Author
miss-islington
commented
May 24, 2020
miss-islington commented
May 24, 2020@remilapeyre and @pablogsal: Status check is done, and it's a success ✅ .
miss-islington
merged commit
1a4e9e6
into
python:3.9
bedevere-bot
removed
the
awaiting merge
label
miss-islington
deleted the
backport-c73914a-3.9
branch
Copy link Copy Markdown
Contributor Author
miss-islington
commented
May 24, 2020
miss-islington commented
May 24, 2020@remilapeyre and @pablogsal: Status check is done, and it's a success ✅ .
1 similar comment
Copy link Copy Markdown
Contributor Author
miss-islington
commented
May 24, 2020
miss-islington commented
May 24, 2020@remilapeyre and @pablogsal: Status check is done, and it's a success ✅ .
pablogsal
changed the title
[3.9] bpo-36290: Fix keytword collision handling in AST node constructors (GH-12382)
[3.9] bpo-36290: Fix keyword collision handling in AST node constructors (GH-12382)
Copy link Copy Markdown
Contributor Author
miss-islington
commented
May 24, 2020
miss-islington commented
May 24, 2020@remilapeyre and @pablogsal: Status check is done, and it's a success ✅ .
1 similar comment
Copy link Copy Markdown
Contributor Author
miss-islington
commented
May 24, 2020
miss-islington commented
May 24, 2020@remilapeyre and @pablogsal: Status check is done, and it's a success ✅ .
Copy link Copy Markdown
Member
pablogsal
commented
May 24, 2020
pablogsal commented
May 24, 2020It's maybe a bit too late, but there's a minor typo in the title here, in #20366 and the master commit message. (keytword -> keyword)
🤦
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants