bpo-37999: Fix outdated __int__ and nb_int references in comments by mdickinson · Pull Request #20449

bpo-37999: Fix outdated __int__ and nb_int references in comments by mdickinson · Pull Request #20449 · python/cpython

Conversation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to catch it!

		Using :meth:`__int__` is deprecated.

		.. versionchanged:: 3.10
		This function will no longer use :meth:`__int__`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually also remove corresponding deprecated directives when the deprecated feature has been removed. So I suggest to remove deprecated few lines above.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mdickinson deleted the fix/long-object-function-descriptions branch

May 27, 2020 12:43

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Labels