Home Original page

bpo-36346: Make unicodeobject.h C89 compatible by methane · Pull Request #20934 · python/cpython

@methane

@methane

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @methane for commit 8b54cb7 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I suggest to change the commit title to "Make unicodeobject.h C89 compatible".

Py_UNICODE_FILL(Py_UNICODE *target, Py_UNICODE value, Py_ssize_t length) {
for (Py_ssize_t i = 0; i < length; i++) {
Py_ssize_t i;
for (i = 0; i < length; i++) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes me sad :-( But well, as I wrote in the issue, I think that it's a good practice to try to keep C89 support for the public C API.

@methane methane changed the title bpo-36346: Fix buildbots bpo-36346: Make unicodeobject.h C89 compatible

Jun 17, 2020

methane added a commit to methane/cpython that referenced this pull request

Jun 17, 2020