bpo-40275: Fix failed test cases by using test helpers by shihai1991 · Pull Request #21811 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@shihai1991

Copy link Copy Markdown

Member

@shihai1991 shihai1991 commented

Aug 10, 2020

edited by bedevere-bot

Loading

@shihai1991 shihai1991 requested a review from a team as a code owner

August 10, 2020 16:02

@bedevere-bot bedevere-bot added tests

Tests in the Lib/test dir

awaiting review labels

Aug 10, 2020

@shihai1991

Copy link Copy Markdown

Member Author

@vstinner

Copy link Copy Markdown

Member

Sadly, all GitHub actions are skipped. My #21806 PR should fix it.

@vstinner

Copy link Copy Markdown

Member

Ah! It's now better with repaired GH Action jobs (no longer skipped)! I'm more confident to merge the PR. I see that macOS is green again, thanks @shihai1991!

shihai1991 reacted with hooray emoji

@vstinner vstinner merged commit 490c542 into python:master

Aug 10, 2020

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Aug 20, 2020

xzy3 pushed a commit to xzy3/cpython that referenced this pull request

Oct 18, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot