gh-78143: IDLE - replace config dlg scale with ttk spinbox by roseman · Pull Request #22954 · python/cpython

@roseman

- replace scale with ttk.Spinbox
- if ttk.Spinbox not available (Tk < 8.5.9) use readonly ttk.Combobox (as both fully constrain available choices)
- note that test originally tried to set a value above the maximum range and relied on the scale adjusting it to the maximum; without adding extra validation code, neither the spinbox or the combobox will do this; given that neither allows arbitrary input, I adjusted the test to provide a value within range

@terryjreedy

@roseman

- replace scale with ttk.Spinbox
- if ttk.Spinbox not available (Tk < 8.5.9) use readonly ttk.Combobox (as both fully constrain available choices)
- note that test originally tried to set a value above the maximum range and relied on the scale adjusting it to the maximum; without adding extra validation code, neither the spinbox or the combobox will do this; given that neither allows arbitrary input, I adjusted the test to provide a value within range

@terryjreedy @roseman

@roseman

@roseman

@terryjreedy

@terryjreedy

terryjreedy

@terryjreedy

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 10, 2021
If ttk.Spinbox is not available (Tk < 8.5.9) use readonly ttk.Combobox.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 42d5a4f)

Co-authored-by: Mark Roseman <mark@markroseman.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 10, 2021
If ttk.Spinbox is not available (Tk < 8.5.9) use readonly ttk.Combobox.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 42d5a4f)

Co-authored-by: Mark Roseman <mark@markroseman.com>

miss-islington added a commit that referenced this pull request

Jun 10, 2021
If ttk.Spinbox is not available (Tk < 8.5.9) use readonly ttk.Combobox.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 42d5a4f)

Co-authored-by: Mark Roseman <mark@markroseman.com>

terryjreedy pushed a commit that referenced this pull request

Jun 10, 2021
If ttk.Spinbox is not available (Tk < 8.5.9) use readonly ttk.Combobox.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 42d5a4f)

Co-authored-by: Mark Roseman <mark@markroseman.com>

@terryjreedy terryjreedy changed the title bpo-33962: replace idle config dlg scale with ttk spinbox gh-78143: IDLE - replace config dlg scale with ttk spinbox

Aug 15, 2022

This was referenced

Aug 15, 2022