Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test case to confirm that the regression is fixed by this?

You can rename test_bad_target_none to test_bad_target and add the new test here:

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And this is actually need a NEWS entry because the previous PR has already been released in 3.10 alphas.

Could you please add a test case to confirm that the regression is fixed by this?

Sure, I'll do it first thing tomorrow.

And this is actually need a NEWS entry because the previous PR has already been released in 3.10 alphas.

I see. Thanks for the heads-up.

BTW, will you have time to review #24203 and #24421 any time soon?

BTW, will you have time to review #24203 and #24421 any time soon?

I'm on holidays at the moment so will see :) They are definitely on my TODO list, though.

BTW, will you have time to review #24203 and #24421 any time soon?

I'm on holidays at the moment so will see :) They are definitely on my TODO list, though.

Oops, sorry! Enjoy your days off :) Thanks!

(I have made the requested changes; please review again)

BTW, not sure about the NEWS entry. It felt a bit clumsy. Let me know if you want me to rephrase it.

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.