[2.7] bpo-30843: regrtest fixes sys.path, restore test.bisect by vstinner · Pull Request #2567 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
[2.7] bpo-30843: regrtest fixes sys.path, restore test.bisect#2567
vstinner merged 1 commit intopython:2.7from
vstinner:regrtest_path27
[2.7] bpo-30843: regrtest fixes sys.path, restore test.bisect#2567
vstinner merged 1 commit intopython:2.7from
vstinner:regrtest_path27
Conversation
Copy link Copy Markdown
Member
vstinner
commented
Jul 4, 2017
vstinner
commented
- Rename again Lib/test/bisectcmd.py to Lib/test/bisect.py
- regrtest now removes '' and Lib/test/ from sys.path
- Use absolute import in test_bisect
* Rename again Lib/test/bisectcmd.py to Lib/test/bisect.py * regrtest now removes '' and Lib/test/ from sys.path * Use absolute import in test_bisect
vstinner
requested review from
brettcannon and
ncoghlan
the-knights-who-say-ni
added
the
CLA signed
label
brettcannon approved these changes Jul 5, 2017
ncoghlan approved these changes Jul 5, 2017
vstinner
merged commit
3050987
into
python:2.7
vstinner
deleted the
regrtest_path27
branch
Copy link Copy Markdown
Member Author
vstinner
commented
Jul 5, 2017
vstinner commented
Jul 5, 2017Thank you @brettcannon and @ncoghlan, I wasn't confident in that change since my previous attempt introduced a strange bug in multiprocessing when the test is run again. But I like @ncoghlan analysis of the regrtest bug introducing Lib/test/ in sys.path. Let's see how buildbots like test.bisect ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants