Home Original page

bpo-44135: issubclass documentation doesn't explain tuple semantic by zkneupper · Pull Request #26193 · python/cpython

Conversation

@zkneupper zkneupper changed the title Address https://bugs.python.org/issue44135 bpo-44135: issubclass documentation doesn't explain tuple semantic

May 17, 2021

Fidget-Spinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thanks for submitting this PR.

@Fidget-Spinner

BTW, I think it would be better if your issue title summarised what the change is about. So maybe bpo-xxxxx:improve explanation of tuple semantics in issubclass docs or something like that?

@zkneupper

BTW, I think it would be better if your issue title summarised what the change is about. So maybe bpo-xxxxx:improve explanation of tuple semantics in issubclass docs or something like that?

Thanks for the suggestion. I'll try to do a better job of naming PRs in the future. :)

@github-actions

This PR is stale because it has been open for 30 days with no activity.

@Fidget-Spinner

Sorry for the long wait Zack.

@ambv sorry can I trouble you to take a look at this please? I'd appreciate a second pair of eyes.

@miss-islington

Thanks @zkneupper for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 31, 2021 
…ehaves (pythonGH-26193)

Co-authored-by: Zachary Kneupper <zachary.kneupper@gmail.com>
(cherry picked from commit 08767c7)

Co-authored-by: Zack Kneupper <zachary.kneupper@gmail.com>

@bedevere-bot

miss-islington added a commit that referenced this pull request

Aug 31, 2021 
…ehaves (GH-26193)

Co-authored-by: Zachary Kneupper <zachary.kneupper@gmail.com>
(cherry picked from commit 08767c7)

Co-authored-by: Zack Kneupper <zachary.kneupper@gmail.com>

ambv added a commit to ambv/cpython that referenced this pull request

Aug 31, 2021 
…ehaves (pythonGH-26193)

This is a quasi-backport to 3.9 since the wording in this branch is different.

Co-authored-by: Zachary Kneupper zachary.kneupper@gmail.com

ambv added a commit that referenced this pull request

Aug 31, 2021 
…ehaves (GH-26193) (GH-28094)

This is a quasi-backport to 3.9 since the wording in this branch is different.

Co-authored-by: Zachary Kneupper zachary.kneupper@gmail.com

Labels