bpo-30779: IDLE: fix delete_section calls in configdialog by csabella · Pull Request #2667 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.5k
Merged
terryjreedy merged 2 commits intopython:masterfrom
Jul 11, 2017Merged
bpo-30779: IDLE: fix delete_section calls in configdialog#2667
terryjreedy merged 2 commits intopython:masterfrom
bpo-30779: IDLE: fix delete_section calls in configdialog#2667
terryjreedy merged 2 commits intopython:masterfrom
Conversation
Copy link Copy Markdown
Contributor
csabella
commented
Jul 11, 2017
csabella
commented
changes.delete_section requires 2 parameters, so I was receiving an error message when trying to delete a custom theme.
Copy link Copy Markdown
mention-bot
commented
Jul 11, 2017
mention-bot commented
Jul 11, 2017@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @kbkaiser and @mlouielu to be potential reviewers.
the-knights-who-say-ni
added
the
CLA signed
label
csabella
changed the title
bpo30779: IDLE: fix for delete section in configdialog
bpo-30779: IDLE: fix for delete section in configdialog
terryjreedy
added
the
needs backport to 3.6
label
terryjreedy
changed the title
bpo-30779: IDLE: fix for delete section in configdialog
bpo-30779: IDLE: fix delete_section calls in configdialog
terryjreedy
merged commit
6d13b22
into
python:master
Copy link Copy Markdown
Member
terryjreedy
commented
Jul 11, 2017
terryjreedy commented
Jul 11, 2017Original error was in commit f22fc6e of PR 2612.
terryjreedy pushed a commit to terryjreedy/cpython that referenced this pull request
Jul 11, 2017…og (pythonGH-2667) Also improve test of config.ConfigChanges.delete_section. Original patch by Cheryl Sabella. (cherry picked from commit 6d13b22)
terryjreedy
mentioned this pull request
Copy link Copy Markdown
bedevere-bot
commented
Jul 11, 2017
bedevere-bot commented
Jul 11, 2017GH-2674 is a backport of this pull request to the 3.6 branch.
bedevere-bot
removed
the
needs backport to 3.6
label
terryjreedy added a commit that referenced this pull request
Jul 11, 2017
csabella
deleted the
bpo30779
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants