bpo-42064: Remove stale extern declarations in `sqlite3` headers by erlend-aasland · Pull Request #26840 · python/cpython
erlend-aasland
changed the title
bpo-42064: Remove stale extern declarations in
bpo-42064: Remove stale extern declarations in sqlite3sqlite3 headers
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, we may need to update Tools/c-analyzer/cpython/ignored.tsv
See:
| Modules/_sqlite/connection.h - pysqlite_ConnectionType - |
IMHO, we may need to update
Tools/c-analyzer/cpython/ignored.tsv
I didn't know about this; thanks for the heads up! I'll update the PR. UPDATE: fixed in 285b341
Erlend E. Aasland added 2 commits
June 23, 2021 08:29
@corona10 I'll have an extra look at this later today; there's a lot more that can be removed from the c-analyzer ignore list.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters