bpo-42064: Move `sqlite3` exceptions to global state, part 2 of 2 by erlend-aasland · Pull Request #26884 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.5k
Merged
miss-islington merged 5 commits intopython:mainfrom
Jul 14, 2021Merged
bpo-42064: Move sqlite3 exceptions to global state, part 2 of 2#26884
miss-islington merged 5 commits intopython:mainfrom
bpo-42064: Move sqlite3 exceptions to global state, part 2 of 2#26884
miss-islington merged 5 commits intopython:mainfrom
Conversation
Copy link Copy Markdown
Contributor
https://bugs.python.org/issue42064
Automerge-Triggered-By: GH:encukou
erlend-aasland
requested a review
from berkerpeksag
as a code owner
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
erlend-aasland
added
the
skip news
label
erlend-aasland
requested a review
from encukou
erlend-aasland
force-pushed
the
sqlite-move-err/2
branch
from
936d7d0 to
f3c4781
Compare
Copy link Copy Markdown
Contributor Author
erlend-aasland
commented
Jun 23, 2021
erlend-aasland commented
Jun 23, 2021FYI, for check_cursor and pysqlite_check_connection, we cannot rely on the connection context exception pointers (at least not for the early sanity checks), so I'm using the global state in those methods.
Erlend E. Aasland added 3 commits
June 23, 2021 22:46
erlend-aasland
force-pushed
the
sqlite-move-err/2
branch
from
f3c4781 to
c79de0c
Compare
erlend-aasland
closed this
erlend-aasland
reopened this
Copy link Copy Markdown
Contributor Author
erlend-aasland
commented
Jun 23, 2021
erlend-aasland commented
Jun 23, 2021(Re-opening to trigger CI again)
Copy link Copy Markdown
Contributor Author
erlend-aasland
commented
Jul 5, 2021
erlend-aasland commented
Jul 5, 2021cc. @encukou
encukou reviewed Jul 13, 2021
Modules/_sqlite/module.c Outdated
Erlend E. Aasland added 2 commits
July 13, 2021 23:10- Use ADD_TYPE() - Naming: name => exc
encukou
added
the
🤖 automerge
label
encukou approved these changes Jul 14, 2021
Copy link Copy Markdown
Member
encukou
left a comment
encukou
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
miss-islington
merged commit
0516299
into
python:main
bedevere-bot
removed
the
awaiting merge
label
Copy link Copy Markdown
Contributor Author
erlend-aasland
commented
Jul 14, 2021
erlend-aasland commented
Jul 14, 2021Looks good, thanks!
Thanks for reviewing!
erlend-aasland
deleted the
sqlite-move-err/2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment