bpo-27268: Fix incorrect error message on float('') by pslacerda · Pull Request #2745 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

csabella merged 2 commits intopython:masterfrom

pslacerda:fix-issue-27268

May 17, 2019

Merged

bpo-27268: Fix incorrect error message on float('')#2745

csabella merged 2 commits intopython:masterfrom

pslacerda:fix-issue-27268

Conversation

@pslacerda

Copy link Copy Markdown

Contributor

@pslacerda pslacerda commented

Jul 18, 2017

edited by bedevere-bot

Loading

@csabella

Copy link Copy Markdown

Contributor

@rhettinger, you approved this awhile ago. Were you waiting on anything in order to merge it? Thanks!

@csabella csabella merged commit 4fa7504 into python:master

May 17, 2019

@csabella

Copy link Copy Markdown

Contributor

@pslacerda, thanks for the pull request. Your change has now been merged. 🎉 🎉

@pslacerda

Copy link Copy Markdown

Contributor Author

Thank you @csabella, I just got something from the issue tracker and put here. Did you imagine someone (especially novices) really tricked seeing such weird error message?

I'm glad it was merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@pslacerda @csabella @rhettinger @auvipy @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot @pslacerda1