[3.10] bpo-33349: make lib2to3 parse async generators everywhere (GH-6588) by miss-islington · Pull Request #27702 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

Copy link Copy Markdown

Contributor

@miss-islington miss-islington commented

Aug 10, 2021

edited by bedevere-bot

Loading

(cherry picked from commit 149addd)

Co-authored-by: Zsolt Dollenstein zsol.zsol@gmail.com

https://bugs.python.org/issue33349

(cherry picked from commit 149addd)

Co-authored-by: Zsolt Dollenstein <zsol.zsol@gmail.com>

@miss-islington

Copy link Copy Markdown

Contributor Author

@zsol and @ambv: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link Copy Markdown

Contributor Author

@zsol and @ambv: Status check is done, and it's a failure ❌ .

@ambv ambv changed the title [3.10] make lib2to3 parse async generators everywhere (GH-6588) [3.10] bpo-33349: make lib2to3 parse async generators everywhere (GH-6588)

Aug 10, 2021

@miss-islington

Copy link Copy Markdown

Contributor Author

@zsol and @ambv: Status check is done, and it's a success ✅ .

@ambv ambv requested a review from pablogsal

August 10, 2021 09:55

@ambv

Copy link Copy Markdown

Contributor

ambv commented

Aug 10, 2021

@pablogsal, while lib2to3 is deprecated, it was unable to parse valid 3.7+ code with regular functions that created async generators. This fixes it.

@miss-islington miss-islington merged commit 52d481f into python:3.10

Aug 10, 2021

@miss-islington miss-islington deleted the backport-149addd-3.10 branch

August 10, 2021 13:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miss-islington @ambv @pablogsal @the-knights-who-say-ni @bedevere-bot @zsol