bpo-35970: Add help flag to base64 module by ammaraskar · Pull Request #28774 · python/cpython

Conversation

@ammaraskar

Copy link Copy Markdown

Member

@ammaraskar ammaraskar commented

Oct 6, 2021

edited by miss-islington

Loading

This continues off rkuska's work from #11789 seeing as the patch wasn't updated to add tests.

https://bugs.python.org/issue35970

Automerge-Triggered-By: GH:ammaraskar

Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
Copy link Copy Markdown

Member

@shihai1991 shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@shihai1991 shihai1991 shihai1991 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ammaraskar @serhiy-storchaka @shihai1991 @the-knights-who-say-ni @bedevere-bot @miss-islington @rkuska