bpo-42222: Improve tests for invalid argument types in randrange() by serhiy-storchaka · Pull Request #29021 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@serhiy-storchaka

Copy link

Member

@serhiy-storchaka serhiy-storchaka commented

Oct 18, 2021

edited by bedevere-bot

Loading

There were duplicate tests and some tests were removed in previous commit.

https://bugs.python.org/issue42222

@miss-islington

Copy link

Contributor

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

Copy link

Contributor

Sorry @serhiy-storchaka and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 574241632bd19e56ed488ee4d8999aefc6a8d7cd 3.10

@ambv ambv added needs backport to 3.10

only security fixes

and removed needs backport to 3.10

only security fixes

labels

Oct 19, 2021

@miss-islington

Copy link

Contributor

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

Copy link

Contributor

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 574241632bd19e56ed488ee4d8999aefc6a8d7cd 3.10

@ambv ambv removed the needs backport to 3.10

only security fixes

label

Oct 19, 2021

@ambv

Copy link

Contributor

ambv commented

Oct 19, 2021

Forget the backport, the original change was in 3.11 actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

@ambv ambv

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @miss-islington @ambv @the-knights-who-say-ni @bedevere-bot