bpo-45654: freeze runpy module by kumaraditya303 · Pull Request #29903 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
gvanrossum merged 5 commits intopython:mainfrom
Dec 9, 2021Merged
bpo-45654: freeze runpy module#29903
gvanrossum merged 5 commits intopython:mainfrom
bpo-45654: freeze runpy module#29903
gvanrossum merged 5 commits intopython:mainfrom
Conversation
Copy link Copy Markdown
Contributor
kumaraditya303 and others added 2 commits
December 3, 2021 16:39
kumaraditya303
requested a review
from a team
as a code owner
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
Copy link Copy Markdown
Contributor Author
kumaraditya303
commented
Dec 4, 2021
kumaraditya303 commented
Dec 4, 2021cc @gvanrossum
Copy link Copy Markdown
Member
gvanrossum
commented
Dec 4, 2021
gvanrossum commented
Dec 4, 2021Did you regen all?
Copy link Copy Markdown
Contributor Author
kumaraditya303
commented
Dec 4, 2021
kumaraditya303 commented
Dec 4, 2021Did you regen all?
Done
Copy link Copy Markdown
Contributor Author
kumaraditya303
commented
Dec 9, 2021
kumaraditya303 commented
Dec 9, 2021@gvanrossum Added news also, anything else left ?
gvanrossum reviewed Dec 9, 2021
Copy link Copy Markdown
Member
gvanrossum
left a comment
gvanrossum
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know by how much the binary size increased?
Copy link Copy Markdown
Contributor Author
Do you know by how much the binary size increased?
Around 250 ~ KB on windows 11 64 bit
Copy link Copy Markdown
Member
gvanrossum
commented
Dec 9, 2021
gvanrossum commented
Dec 9, 2021Okay, that's acceptable. I'll approve and merge then -- the Azure Pipelines PR failure seems a flake.
gvanrossum approved these changes Dec 9, 2021
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
gvanrossum
merged commit
44b0e76
into
python:main
bedevere-bot
removed
the
awaiting merge
label
Copy link Copy Markdown
Member
gvanrossum
commented
Dec 9, 2021
gvanrossum commented
Dec 9, 2021Thanks for your contribution!
kumaraditya303
deleted the
runpy
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants