bpo-45774: Harden SQLite detection by erlend-aasland · Pull Request #30016 · python/cpython

@erlend-aasland

- Beautify configure output
- Make sure vital functions are in place

arhadthedev

Erlend E. Aasland added 3 commits

December 10, 2021 10:29
Reindent contents of AC_ARG_ENABLE

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit f5b0552 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@erlend-aasland

Regarding the buildbot run: SQLite is correctly detected and the sqlite3 module is built, AFAICS. The two failures seem to be unrelated.

@erlend-aasland

@tiran, are you ok with this PR? For those of us who've got multiple SQLite installations with completely different configurations, it's nice to fail early with configure rather than wait for a link error at the end of compilation.

@erlend-aasland

Regarding the buildbot run:

  • AMD64 Arch Linux ASAN failed at test_multiprocessing_fork
  • PPC64LE RHEL7 Refleaks failed at test_typing

Both failures are unrelated to this PR.

@erlend-aasland

gpshead

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm filing this one under Pedantically Correct. I'd not expect anyone to have an installed detectable sqlite3 ever built using various defines neutering the library. But if they do, this likely does a better job at detecting that and avoiding it.

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @gpshead for commit e8558da 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@erlend-aasland

I'm filing this one under Pedantically Correct. I'd not expect anyone to have an installed detectable sqlite3 ever built using various defines neutering the library.

I do, I do! ✋🏻 (Mostly for testing weird stuff like this)

OTOH, we never know what kind of SQLite library will show up when we're running Python in the browser.

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @tiran for commit 55f79a5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@arhadthedev

@tiran

@tiran PPC64LE failure is sporadic, a rerun is required:

fatal: unable to access 'python/cpython.git': Could not resolve host: github.com

The buildbot started to fail consistently two days ago. I have contacted Charris to look into the problem an hour ago.

@miss-islington

16 similar comments

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@miss-islington

@tiran

The Windows refleak, PPC64LE, and s390x issues are unrelated to the PR. The s390x issue is addressed in GH-32332.