bpo-40280: Add --with-emscripten-target to build for browser or node (GH-30552) by tiran · Pull Request #30552 · python/cpython
Conversation
Co-authored-by: Ethan Smith <ethan@ethanhs.me> Signed-off-by: Christian Heimes <christian@python.org>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two suggestions but otherwise this looks good! It is a bit unfortunate that running emmake make after the correct configure doesn't "just work" but alas.
Two suggestions but otherwise this looks good! It is a bit unfortunate that running
emmake makeafter the correct configure doesn't "just work" but alas.
It does now :)
tiran
marked this pull request as ready for review
tiran
mentioned this pull request
tiran
changed the title
bpo-40280: Add --with-emscripten-target to build for browser or node
bpo-40280: Add --with-emscripten-target to build for browser or node (GH-30552)
tiran
deleted the
bpo-40280-emscripten-targets
branch
This was referenced
Jan 12, 2022This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters