Add myself as a codeowner for Windows-specific files by zooba · Pull Request #3089 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
Add myself as a codeowner for Windows-specific files#3089
zooba merged 2 commits intopython:masterfrom
Add myself as a codeowner for Windows-specific files#3089
zooba merged 2 commits intopython:masterfrom
Conversation
zooba
added
skip issue
skip news
labels
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting merge
label
Copy link Copy Markdown
Member Author
zooba
commented
Aug 14, 2017
zooba commented
Aug 14, 2017Copy link Copy Markdown
Member
zware
commented
Aug 14, 2017
zware commented
Aug 14, 2017How about a Windows team?
Copy link Copy Markdown
Member Author
zooba
commented
Aug 14, 2017
zooba commented
Aug 14, 2017No strong opinion - do we just ping @brettcannon for one of those?
Copy link Copy Markdown
Member
brettcannon
commented
Aug 14, 2017
brettcannon commented
Aug 14, 2017@zooba yep, you can just ask me. Tell me who should be on it initially and I will create a python/windows-team (which all team members can then manage on their own going forward).
Copy link Copy Markdown
Member
Just chipping in for long enough to say: please do include me in any Windows team, in the hope that I'll actually find enough time to do something useful any time soon!
Copy link Copy Markdown
Member Author
zooba
commented
Aug 15, 2017
zooba commented
Aug 15, 2017@brettcannon Start with the @'s I put above - that's our current set of listed experts.
Copy link Copy Markdown
Member
brettcannon
commented
Aug 15, 2017
brettcannon commented
Aug 15, 2017@zooba Done! https://github.com/orgs/python/teams/windows-team/members. Now you can update your PR to reference @python/windows-team instead of yourself.
Copy link Copy Markdown
Member Author
zooba
commented
Aug 15, 2017
zooba commented
Aug 15, 2017Done. Briefly considered not signing you all up for installer change notifications, but then did it anyway. Enjoy :)
zooba
merged commit
1f512b9
into
python:master
zooba
deleted the
windows-codeowner
branch
Mariatta
removed
the
awaiting merge
label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment