bpo-45150: Add hashlib.file_digest() for efficient file hashing by tiran · Pull Request #31930 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.3k
Merged
miss-islington merged 6 commits intopython:mainfrom
Mar 22, 2022Merged
bpo-45150: Add hashlib.file_digest() for efficient file hashing#31930
miss-islington merged 6 commits intopython:mainfrom
bpo-45150: Add hashlib.file_digest() for efficient file hashing#31930
miss-islington merged 6 commits intopython:mainfrom
Conversation
bedevere-bot
added
the
awaiting core review
label
the-knights-who-say-ni
added
the
CLA signed
label
tiran
force-pushed
the
bpo-45150-file-digest
branch
from
1d6869b to
9b218da
Compare
tiran
force-pushed
the
bpo-45150-file-digest
branch
from
9b218da to
71f0401
Compare
tiran added 2 commits
March 16, 2022 13:50
tiran
requested a review
from gpshead
gpshead requested changes Mar 16, 2022
Copy link
Member
gpshead
left a comment
gpshead
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you implemented this in pure Python.
Lib/hashlib.py
Outdated
Show resolved
Hide resolved
Lib/hashlib.py Outdated Show resolved Hide resolved
Lib/hashlib.py
Outdated
Show resolved
Hide resolved
Lib/hashlib.py Outdated Show resolved Hide resolved
Lib/test/test_hashlib.py
Show resolved
Hide resolved
Lib/test/test_hashlib.py Show resolved Hide resolved
Doc/library/hashlib.rst
Outdated
Show resolved
Hide resolved
Doc/library/hashlib.rst Outdated Show resolved Hide resolved
bedevere-bot
added
awaiting changes
and removed
awaiting core review
labels
Copy link
bedevere-bot
commented
Mar 16, 2022
bedevere-bot commented
Mar 16, 2022When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
gpshead
mentioned this pull request
tiran
requested a review
from gpshead
tiran
added
awaiting core review
and removed
awaiting changes
labels
gpshead reviewed Mar 17, 2022
Lib/test/test_hashlib.py
Outdated
Show resolved
Hide resolved
Lib/test/test_hashlib.py Outdated Show resolved Hide resolved
gpshead approved these changes Mar 21, 2022
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
gpshead reviewed Mar 21, 2022
Lib/test/test_hashlib.py
Outdated
Show resolved
Hide resolved
Lib/test/test_hashlib.py Outdated Show resolved Hide resolved
tiran
requested a review
from gpshead
gpshead approved these changes Mar 22, 2022
tiran
added
the
🤖 automerge
label
miss-islington
merged commit
4f97d64
into
python:main
bedevere-bot
removed
the
awaiting merge
label
Copy link
Member
markshannon
commented
Mar 22, 2022
markshannon commented
Mar 22, 2022This may have broken the buildbots.
https://buildbot.python.org/all/#/builders/713/builds/452
Copy link
Member Author
tiran
commented
Mar 22, 2022
tiran commented
Mar 22, 2022This may have broken the buildbots. buildbot.python.org/all/#/builders/713/builds/452
FIPS ... let's see if GH-32046 solves the issue.
tiran
deleted the
bpo-45150-file-digest
branch
tiran
mentioned this pull request
tarekziade
mannequin
mentioned this pull request
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment