bpo-31234, socket.create_connection(): Fix ref cycle by vstinner ยท Pull Request #3546 ยท python/cpython

Conversation

gpshead

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rearrange the words in the comments to say "explicitly break" and "manually fixes" for correct English. Though people will understand it either way.

@vstinner

Hum, for the english, I will create a different PR since I copied the comment from somewhere else.

@miss-islington

Thanks @Haypo for the PR ๐ŸŒฎ๐ŸŽ‰.. I'm working now to backport this PR to: 3.6.
๐Ÿ๐Ÿ’โ›๐Ÿค–

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 13, 2017

vstinner pushed a commit that referenced this pull request

Sep 13, 2017