[3.8] bpo-31508: Remove support of arguments in tkinter.ttk.Treeview.selection. by serhiy-storchaka · Pull Request #3651 · python/cpython
…ion. It was deprecated in 3.6.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
- You fixed the warn for which I complained
- You documented the change and explained how to upgrade the code
- You wrote a NEWS entry
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM.
It's up to you to apply this one or PR #3667.
I think you should apply #3667 now, for 3.7, and this after 3.7 is branched off, for 3.8.
serhiy-storchaka
changed the title
bpo-31508: Remove support of arguments in tkinter.ttk.Treeview.selection.
[3.8] bpo-31508: Remove support of arguments in tkinter.ttk.Treeview.selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters