bpo-31853: Replaced socket.method calls with super() in SSLSocket. by atombrella · Pull Request #4048 · python/cpython

@atombrella

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@atombrella atombrella changed the title Replaced socket.method calls with super() in SSLSocket. bpo-31853: Replaced socket.method calls with super() in SSLSocket.

Oct 23, 2017

@atombrella

@tiran Is there anything stalling this?

tiran

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot about your patch. LGTM, please fix indention and I'll merge it later today.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix indention

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be done. One attribute per line seems to be the style.

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@atombrella

tiran

@tiran

Yeah, it looks fine now. Thanks for your contribution

@bedevere-bot

@tiran: Please replace # with GH- in the commit message next time. Thanks!