Home Original page

bpo-31174: Improve the code of test_tools.test_unparse. by serhiy-storchaka · Pull Request #4146 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@serhiy-storchaka

Copy link Copy Markdown

Member

@serhiy-storchaka serhiy-storchaka commented

Oct 27, 2017

•

edited by bedevere-bot

Loading

If get_names() is an instance method, it shouldn't cache its result statically. It should be a static method, but a class method works as well.

https://bugs.python.org/issue31174

Copy link Copy Markdown

Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 7351f9e into python:master

Oct 27, 2017

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test_unparse-get_names branch

October 27, 2017 12:35

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 27, 2017

@bedevere-bot

Copy link Copy Markdown

GH-4148 is a backport of this pull request to the 3.6 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni