Home Original page

bpo-31947: names=None case is not handled by EnumMeta._create_ method by anentropic · Pull Request #4288 · python/cpython

@anentropic 

It seems to me that this method should not have `names=None` default value in signature, because that case is not handled, nor is it described as a possible value in the docstring.

Seems like maybe a copy and paste from `__call__`, which has basically same signature, but `names=None` is valid and handled there.

Or I humbly admit maybe there's something more going on that I'm not aware of. Anyway, I propose this small change.

@anentropic anentropic changed the title names=None case is not handled by EnumMeta._create_ method names=None case is not handled by EnumMeta._create_ method bpo-31947

Nov 5, 2017

@serhiy-storchaka serhiy-storchaka changed the title names=None case is not handled by EnumMeta._create_ method bpo-31947 bpo-31947: names=None case is not handled by EnumMeta._create_ method

Mar 26, 2018

ethanfurman

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 16, 2018 
…onGH-4288)

(cherry picked from commit b8e21f1)

Co-authored-by: anentropic <ego@anentropic.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 16, 2018 
…onGH-4288)

(cherry picked from commit b8e21f1)

Co-authored-by: anentropic <ego@anentropic.com>

miss-islington added a commit that referenced this pull request

Apr 16, 2018 
)

(cherry picked from commit b8e21f1)

Co-authored-by: anentropic <ego@anentropic.com>

ethanfurman pushed a commit that referenced this pull request

May 15, 2018 
… (GH-6485)

(cherry picked from commit b8e21f1)

Co-authored-by: anentropic <ego@anentropic.com>