Home Original page

bpo-29711: Fix stop_serving in proactor loop kill all listening servers by julien-duponchelle · Pull Request #431 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@julien-duponchelle

Copy link Copy Markdown

Contributor

@julien-duponchelle julien-duponchelle commented

Mar 3, 2017

•

edited by bedevere-bot

Loading

Current implementation of the asyncio Proactor event loop has an issue, when you stop a server it's cancel the futures of all other servers.

Original discussion: python/asyncio#496

https://bugs.python.org/issue29711

@mention-bot

Copy link Copy Markdown

@noplay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Haypo and @1st1 to be potential reviewers.

@1st1

Copy link Copy Markdown

Member

1st1 commented

Mar 3, 2017

@Haypo Can you take a look at this PR?

@julien-duponchelle

Copy link Copy Markdown

Contributor Author

Can I do something to help ?

Copy link Copy Markdown

Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner

Copy link Copy Markdown

Member

I agree that it's plain wrong to cancel the "accept future" of all listening servers.

@1st1

Copy link Copy Markdown

Member

1st1 commented

Oct 19, 2017

Could you please add a NEWS entry using blurb?

@1st1 1st1 requested a review from asvetlov

October 19, 2017 17:35

@asvetlov

Copy link Copy Markdown

Contributor

@noplay ping

@julien-duponchelle

Copy link Copy Markdown

Contributor Author

News entry added

@1st1

Copy link Copy Markdown

Member

1st1 commented

Dec 18, 2017

Could you please rebase your PR once again?

@julien-duponchelle

Copy link Copy Markdown

Contributor Author

It's rebase

@1st1 1st1 merged commit 319c034 into python:master

Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@julien-duponchelle @mention-bot @1st1 @vstinner @asvetlov @the-knights-who-say-ni @bedevere-bot