[backport to 2.7] Change documentation's `Show Source` link to GitHub by Mariatta · Pull Request #44 · python/cpython
Change documentation's Show Source link to GitHub (2.7 branch)
Render issue role as bpo-NNNN
Change the url to 2.7 (cherry picked from commit 79ab8be)
| def issue_role(typ, rawtext, text, lineno, inliner, options={}, content=[]): | ||
| issue = utils.unescape(text) | ||
| text = 'issue ' + issue | ||
| text = 'bpo- ' + issue |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there space between 'bpo-' and issue number?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there shouldn't be a space 😅
Thanks for the review :) Will fix soon.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did make html in local, and it works as expected.
LGTM.
Mariatta
changed the title
[backport to 2.7] Support "bpo-" in Misc/NEWS
[backport to 2.7] Change documentation's Show Source link to GitHub
Thanks @methane :) I updated the pull request description.
What do you think?
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Sep 9, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Sep 9, 2019
benjaminp pushed a commit that referenced this pull request
Sep 9, 2019
GH-15301) The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications Change the link to one that points to the current version. Also, use HTTPS.. (cherry picked from commit 64c6ac7) Co-authored-by: Greg Price <gnprice@gmail.com>
benjaminp added a commit that referenced this pull request
Sep 9, 2019
GH-15808) The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications Change the link to one that points to the current version. Also, use HTTPS.. (cherry picked from commit 64c6ac7) Co-authored-by: Greg Price <gnprice@gmail.com>
miss-islington added a commit that referenced this pull request
Sep 9, 2019
…15301) The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications Change the link to one that points to the current version. Also, use HTTPS. (cherry picked from commit 64c6ac7) Co-authored-by: Greg Price <gnprice@gmail.com>
miss-islington added a commit that referenced this pull request
Sep 9, 2019
…15301) The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications Change the link to one that points to the current version. Also, use HTTPS. (cherry picked from commit 64c6ac7) Co-authored-by: Greg Price <gnprice@gmail.com>
jaraco pushed a commit to jaraco/cpython that referenced this pull request
Feb 17, 2023
Fix `contents()` so that it no longer returns unrelated items Closes python#44 See merge request python-devs/importlib_resources!48
This was referenced
Feb 11, 2025This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters