Implement the get_resource_reader() API for file system imports by warsaw · Pull Request #5168 · python/cpython

@warsaw

@warsaw

@brettcannon I've moved the zipimport work to a separate branch, still in progress.

@warsaw

brettcannon

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great overall, but we do need docs for this.

@bedevere-bot

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@warsaw

@warsaw

@warsaw

I have made the requested changes; please review again

@warsaw

@warsaw

@warsaw

@brettcannon Ping. I'm rebasing my zipimporter branch on top of this one, so I'd like to land it soon. See my previous comment about the docs.

brettcannon

@brettcannon

I landed the docs for the ABC, but I didn't document anything relating to the changes in this PR. I've gone ahead and approved this so you can get your zipimporter changes in as we can do doc changes in after b1 if necessary.

@warsaw warsaw deleted the resource-reader branch

January 16, 2018 19:25