bpo-32663 Make SMTPUTF8SimTests run by chason · Pull Request #5314

bpo-32663 Make SMTPUTF8SimTests run by chason · Pull Request #5314 · python/cpython

The tests for SMTPUTF8SimTests in test_smtplib.py were not actually
being run because they were never added to test_main. Additionally, one
of the tests needed to be in the non-UTF8 server class because it relied
on the server not being UTF-8 compatible.

Updating __main__ to call unittest.main() as per bitdancer's request

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 25, 2018

Enable and fix SMTPUTF8SimTests in test_smtplib.

The tests for SMTPUTF8SimTests in test_smtplib.py were not actually
being run because test_smtplib was still using the 'test_main' pattern,
and the class was never added to test_main.

Additionally, one of the tests needed to be moved to the non-UTF8 server
class because it relies on the server not being UTF-8 compatible (and it
had a bug in in).
(cherry picked from commit 48ed88a)

Co-authored-by: chason <chason@gmail.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 25, 2018

Enable and fix SMTPUTF8SimTests in test_smtplib.

The tests for SMTPUTF8SimTests in test_smtplib.py were not actually
being run because test_smtplib was still using the 'test_main' pattern,
and the class was never added to test_main.

Additionally, one of the tests needed to be moved to the non-UTF8 server
class because it relies on the server not being UTF-8 compatible (and it
had a bug in in).
(cherry picked from commit 48ed88a)

Co-authored-by: chason <chason@gmail.com>

bitdancer pushed a commit that referenced this pull request

Jul 26, 2018

Enable and fix SMTPUTF8SimTests in test_smtplib.

The tests for SMTPUTF8SimTests in test_smtplib.py were not actually
being run because test_smtplib was still using the 'test_main' pattern,
and the class was never added to test_main.

Additionally, one of the tests needed to be moved to the non-UTF8 server
class because it relies on the server not being UTF-8 compatible (and it
had a bug in in).
(cherry picked from commit 48ed88a)

Co-authored-by: chason <chason@gmail.com>

bitdancer pushed a commit that referenced this pull request

Jul 26, 2018

Enable and fix SMTPUTF8SimTests in test_smtplib.

The tests for SMTPUTF8SimTests in test_smtplib.py were not actually
being run because test_smtplib was still using the 'test_main' pattern,
and the class was never added to test_main.

Additionally, one of the tests needed to be moved to the non-UTF8 server
class because it relies on the server not being UTF-8 compatible (and it
had a bug in in).
(cherry picked from commit 48ed88a)

Co-authored-by: chason <chason@gmail.com>