bpo-32596: Make lazy-load portable by methane · Pull Request #5316 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@methane

Copy link Copy Markdown

Member

@methane methane commented

Jan 25, 2018

edited by bedevere-bot

Loading

Global variables should not used as import target.
Use temporary variable instead.
Copy link Copy Markdown

Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@methane methane merged commit 4666ec5 into python:master

Jan 26, 2018

@methane methane deleted the concurrent-futures branch

January 26, 2018 01:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane @ilevkivskyi @the-knights-who-say-ni @bedevere-bot