[3.7] bpo-33042: Fix pre-initialization sys module configuration (GH-6157) by miss-islington · Pull Request #6232 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

Copy link Copy Markdown

Contributor

@miss-islington miss-islington commented

Mar 25, 2018

edited by bedevere-bot

Loading

  • new test case for pre-initialization of sys.warnoptions and sys._xoptions
  • restored ability to call these APIs prior to Py_Initialize
  • updated the docs for the affected APIs to make it clear they can be
    called before Py_Initialize
  • also enhanced the existing embedding test cases
    to check for expected settings in the sys module
    (cherry picked from commit bc77eff)

Co-authored-by: Nick Coghlan ncoghlan@gmail.com

https://bugs.python.org/issue33042

…6157)

- new test case for pre-initialization of sys.warnoptions and sys._xoptions
- restored ability to call these APIs prior to Py_Initialize
- updated the docs for the affected APIs to make it clear they can be
  called before Py_Initialize
- also enhanced the existing embedding test cases
  to check for expected settings in the sys module
(cherry picked from commit bc77eff)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>

@miss-islington

Copy link Copy Markdown

Contributor Author

@ncoghlan: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit c6d94c3 into python:3.7

Mar 25, 2018

@miss-islington

Copy link Copy Markdown

Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-bc77eff-3.7 branch

March 25, 2018 11:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @ncoghlan @the-knights-who-say-ni @bedevere-bot