bpo-33454: Fix arguments parsing in _xxsubinterpreters.channel_close(). by serhiy-storchaka · Pull Request #6747 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
serhiy-storchaka merged 1 commit intopython:masterfrom
May 15, 2018Merged
Conversation
Copy link Copy Markdown
Member
serhiy-storchaka
added
type-bug
skip news needs backport to 3.7 labels
May 10, 2018
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting merge
label
ericsnowcurrently approved these changes May 15, 2018
Copy link Copy Markdown
Member
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
serhiy-storchaka
merged commit
d8dcd57
into
python:master
Copy link Copy Markdown
Contributor
miss-islington
commented
May 15, 2018
miss-islington commented
May 15, 2018Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
bedevere-bot
removed
the
awaiting merge
label
serhiy-storchaka
deleted the
xxsubinterpreters-channel-close
branch
Copy link Copy Markdown
Contributor
miss-islington
commented
May 15, 2018
miss-islington commented
May 15, 2018Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d8dcd57edb88ce57063e5c2b85fe0ee1abb1ce8b 3.7
serhiy-storchaka
removed
the
needs backport to 3.7
label
Copy link Copy Markdown
Member Author
serhiy-storchaka
commented
May 16, 2018
serhiy-storchaka commented
May 16, 2018_xxsubinterpreters was removed in 3.7.
serhiy-storchaka
removed their assignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment