bpo-33495: Change dataclasses.Fields repr to use the repr of member by ericvsmith · Pull Request #6798 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

ericvsmith merged 1 commit intopython:masterfrom

ericvsmith:bpo-33495-dataclass-fields-repr

May 14, 2018

Merged

bpo-33495: Change dataclasses.Fields repr to use the repr of member#6798

ericvsmith merged 1 commit intopython:masterfrom

ericvsmith:bpo-33495-dataclass-fields-repr

Conversation

@ericvsmith

Copy link Copy Markdown

Member

@ericvsmith ericvsmith commented

May 14, 2018

edited by serhiy-storchaka

Loading

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 14, 2018
…its members (pythonGH-6798)

(cherry picked from commit 2473eea)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>

@bedevere-bot

Copy link Copy Markdown

GH-6806 is a backport of this pull request to the 3.7 branch.

@ericvsmith ericvsmith changed the title bpo-33494: Change dataclasses.Fields repr to use the repr of member bpo-33495: Change dataclasses.Fields repr to use the repr of member

May 14, 2018

@ericvsmith ericvsmith deleted the bpo-33495-dataclass-fields-repr branch

May 14, 2018 15:41

@pfmoore

Copy link Copy Markdown

Member

pfmoore commented

May 14, 2018

Linked to the wrong issue (33494)?

@ericvsmith

Copy link Copy Markdown

Member Author

Yes, I've since fixed it (I hope). Sorry about that. I should always copy-paste and not trust my fingers.

miss-islington added a commit that referenced this pull request

May 14, 2018
…its members (GH-6798)

(cherry picked from commit 2473eea)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>

jimmylai pushed a commit to jimmylai/cpython that referenced this pull request

May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ericvsmith ericvsmith

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericvsmith @miss-islington @bedevere-bot @pfmoore @the-knights-who-say-ni