bpo-33544: make asyncio.Event awaitable by fried · Pull Request #6916 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.5k
Closed
fried wants to merge 1 commit intopython:masterfrom
Closed
bpo-33544: make asyncio.Event awaitable#6916
fried wants to merge 1 commit intopython:masterfrom
bpo-33544: make asyncio.Event awaitable#6916
fried wants to merge 1 commit intopython:masterfrom
Conversation
Copy link Copy Markdown
Contributor
Inconsistency in asyncio.Event. It was were never made awaitable. This is a hold over from before async/wait, and its surprising. The awaitable pattern is much cleaner
await event
instead of
await event.wait()
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
Copy link Copy Markdown
Member
vstinner
commented
May 17, 2018
vstinner commented
May 17, 2018It seems like you forgot something in your PR. I only see the NEWS entry!?
asvetlov
closed this
Copy link Copy Markdown
Contributor
asvetlov
commented
May 21, 2018
asvetlov commented
May 21, 2018See the rejection reason in the https://bugs.python.org/issue33544
fried
deleted the
awaitable_things
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment