Home Original page

bpo-32610: Fix asyncio.all_tasks() to return only pending tasks. by 1st1 · Pull Request #7174 · python/cpython

Conversation

asvetlov

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation should reflect the difference

def all_tasks(loop=None):
"""Return a set of all tasks for the loop."""
if loop is None:
loop = events.get_event_loop()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_running_loop() maybe?
If all_tasks() is not the same as Task.all_tasks() anymore...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go for running, yes; it was my original request. Let me update the PR.

@1st1

asvetlov

@miss-islington

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@1st1 1st1 deleted the fixall branch

May 28, 2018 21:54

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 28, 2018 
…honGH-7174)

(cherry picked from commit 416c1eb)

Co-authored-by: Yury Selivanov <yury@magic.io>

@bedevere-bot

miss-islington added a commit that referenced this pull request

May 29, 2018 
…7174)

(cherry picked from commit 416c1eb)

Co-authored-by: Yury Selivanov <yury@magic.io>