bpo-33699: Describe try's else clause with the rest of the try clause by andresdelfino · Pull Request #7252 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
miss-islington merged 3 commits intopython:masterfrom
Nov 11, 2018Merged
bpo-33699: Describe try's else clause with the rest of the try clause#7252
miss-islington merged 3 commits intopython:masterfrom
bpo-33699: Describe try's else clause with the rest of the try clause#7252
miss-islington merged 3 commits intopython:masterfrom
Conversation
Copy link Copy Markdown
Contributor
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
taleinat reviewed Jun 12, 2018
Doc/reference/compound_stmts.rst Outdated
taleinat approved these changes Jun 12, 2018
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
taleinat
added
needs backport to 3.6
skip news
labels
Copy link Copy Markdown
Contributor
taleinat
commented
Jun 12, 2018
taleinat commented
Jun 12, 2018IMO this is an improvement, but I'll let someone who has worked on the documentation more make this call.
Copy link Copy Markdown
Member
vstinner
commented
Oct 19, 2018
vstinner commented
Oct 19, 2018cc @1st1 @pablogsal
pablogsal reviewed Oct 20, 2018
Doc/reference/compound_stmts.rst Outdated
pablogsal approved these changes Oct 22, 2018
Copy link Copy Markdown
Member
pablogsal
left a comment
pablogsal
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thank you for the quick response! :)
Copy link Copy Markdown
Contributor Author
andresdelfino
commented
Nov 11, 2018
andresdelfino commented
Nov 11, 2018Don't know a way to get the CI run again so all checks are successful :/
Copy link Copy Markdown
Member
Mariatta
commented
Nov 11, 2018
Mariatta commented
Nov 11, 2018I restarted it
Mariatta approved these changes Nov 11, 2018
Mariatta
added
the
🤖 automerge
label
Copy link Copy Markdown
Contributor
miss-islington
commented
Nov 11, 2018
miss-islington commented
Nov 11, 2018@andresdelfino: Status check is done, and it's a success ✅ .
miss-islington
merged commit
b086c8a
into
python:master
Copy link Copy Markdown
Contributor
miss-islington
commented
Nov 11, 2018
miss-islington commented
Nov 11, 2018Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖
bedevere-bot
removed
the
awaiting merge
label
Copy link Copy Markdown
bedevere-bot
commented
Nov 11, 2018
bedevere-bot commented
Nov 11, 2018GH-10467 is a backport of this pull request to the 3.7 branch.
bedevere-bot
removed
the
needs backport to 3.7
label
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Nov 11, 2018…pythonGH-7252) https://bugs.python.org/issue33699 (cherry picked from commit b086c8a) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
Copy link Copy Markdown
bedevere-bot
commented
Nov 11, 2018
bedevere-bot commented
Nov 11, 2018GH-10468 is a backport of this pull request to the 3.6 branch.
bedevere-bot
removed
the
needs backport to 3.6
label
Copy link Copy Markdown
Contributor
miss-islington
commented
Nov 11, 2018
miss-islington commented
Nov 11, 2018Sorry, @andresdelfino, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b086c8afdb8c862011e3e27d4c8f6833749f2c56 2.7
miss-islington
self-assigned this
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Nov 11, 2018…pythonGH-7252) https://bugs.python.org/issue33699 (cherry picked from commit b086c8a) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
andresdelfino
deleted the
try-else
branch
Copy link Copy Markdown
Contributor Author
andresdelfino
commented
Nov 11, 2018
andresdelfino commented
Nov 11, 2018I restarted it
Thank you :)
miss-islington added a commit that referenced this pull request
Nov 11, 2018…GH-7252) https://bugs.python.org/issue33699 (cherry picked from commit b086c8a) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request
Nov 11, 2018…GH-7252) https://bugs.python.org/issue33699 (cherry picked from commit b086c8a) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
bedevere-bot
removed
the
needs backport to 2.7
label
Copy link Copy Markdown
bedevere-bot
commented
Nov 11, 2018
bedevere-bot commented
Nov 11, 2018GH-10469 is a backport of this pull request to the 2.7 branch.
miss-islington pushed a commit that referenced this pull request
Nov 11, 2018…clause (GH-7252) (GH-10469) https://bugs.python.org/issue33699 (cherry picked from commit b086c8a) https://bugs.python.org/issue33699
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment