bpo-33860: Prefer "OrderedDict" over "ordered dictionary" by andresdelfino · Pull Request #7535 · python/cpython
Conversation
Make it clear that the members special attribute of enums is an OrderedDict, now that "ordered dictionaries" can be somewhat confusing with insertion order being preserved by dict.
andresdelfino
changed the title
Make it clear that we talk about an OrderedDict
bpo-33860: Prefer OrderedDict over ordered dictionary
Issue created :) I merged #7538 into this, because the motivation is the same.
andresdelfino
changed the title
bpo-33860: Prefer OrderedDict over ordered dictionary
bpo-33860: Prefer "OrderedDict" over "ordered dictionary"
This feels like an unnecessary change. The phrase "ordered dictionary" does not always refer to an 'OrderedDict`, and there is more than one way to order a dictionary besides insertion order.
As a side note: it's generally better to have different pull requests for different modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters