bpo-33746: Fix test_unittest when run in verbose mode by vstinner · Pull Request #7799

bpo-33746: Fix test_unittest when run in verbose mode by vstinner · Pull Request #7799 · python/cpython

Only make sure that the result is in unittest.signals._results, don't
check the full content of unittest.signals._results.

support._run_suite() uses TextTestRunner in verbose mode, but
TextTestRunner.run() calls registerResult(result) which made the test
fail with "odd object in result set".

Call also removeResult() to restore unittest.signals._results to
avoid side effect of the test.

Test also assertNotIn() before registerResult().

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 20, 2018

…thonGH-7799)

Only make sure that the result is in unittest.signals._results, don't
check the full content of unittest.signals._results.

support._run_suite() uses TextTestRunner in verbose mode, but
TextTestRunner.run() calls registerResult(result) which made the test
fail with "odd object in result set".

Call also removeResult() to restore unittest.signals._results to
avoid test side effect.
(cherry picked from commit fd8fbce)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 20, 2018

…thonGH-7799)

Only make sure that the result is in unittest.signals._results, don't
check the full content of unittest.signals._results.

support._run_suite() uses TextTestRunner in verbose mode, but
TextTestRunner.run() calls registerResult(result) which made the test
fail with "odd object in result set".

Call also removeResult() to restore unittest.signals._results to
avoid test side effect.
(cherry picked from commit fd8fbce)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

miss-islington added a commit that referenced this pull request

Jun 20, 2018

…-7799)

Only make sure that the result is in unittest.signals._results, don't
check the full content of unittest.signals._results.

support._run_suite() uses TextTestRunner in verbose mode, but
TextTestRunner.run() calls registerResult(result) which made the test
fail with "odd object in result set".

Call also removeResult() to restore unittest.signals._results to
avoid test side effect.
(cherry picked from commit fd8fbce)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

miss-islington added a commit that referenced this pull request

Jun 20, 2018

…-7799)

Only make sure that the result is in unittest.signals._results, don't
check the full content of unittest.signals._results.

support._run_suite() uses TextTestRunner in verbose mode, but
TextTestRunner.run() calls registerResult(result) which made the test
fail with "odd object in result set".

Call also removeResult() to restore unittest.signals._results to
avoid test side effect.
(cherry picked from commit fd8fbce)

Co-authored-by: Victor Stinner <vstinner@redhat.com>