bpo-33975: Avoid small type when running IDLE's htests. by terryjreedy · Pull Request #7944

bpo-33975: Avoid small type when running IDLE's htests. by terryjreedy · Pull Request #7944 · python/cpython

added 2 commits

June 26, 2018 22:24

Import pyshell to call SetProcessDpiAwareness on Windows
before tkinter.Tk() is called in the same process.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 27, 2018

Import pyshell first in htest to call SetProcessDpiAwareness on Windows
before tkinter.Tk() is called for the htest. Apparently, 'root.destroy()'
undoes a previous 'root = Tk()'. Since IDLE unittests always destroy roots,
a unittest before an htest does not require anything more to work right.
Since part of the purpose of human-viewed tests is to determine that
widgets look right, it is important that they look the same for testing
as when running IDLE.
(cherry picked from commit 3c8043d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 27, 2018

Import pyshell first in htest to call SetProcessDpiAwareness on Windows
before tkinter.Tk() is called for the htest. Apparently, 'root.destroy()'
undoes a previous 'root = Tk()'. Since IDLE unittests always destroy roots,
a unittest before an htest does not require anything more to work right.
Since part of the purpose of human-viewed tests is to determine that
widgets look right, it is important that they look the same for testing
as when running IDLE.
(cherry picked from commit 3c8043d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington added a commit that referenced this pull request

Jun 27, 2018

Import pyshell first in htest to call SetProcessDpiAwareness on Windows
before tkinter.Tk() is called for the htest. Apparently, 'root.destroy()'
undoes a previous 'root = Tk()'. Since IDLE unittests always destroy roots,
a unittest before an htest does not require anything more to work right.
Since part of the purpose of human-viewed tests is to determine that
widgets look right, it is important that they look the same for testing
as when running IDLE.
(cherry picked from commit 3c8043d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington added a commit that referenced this pull request

Jun 27, 2018

Import pyshell first in htest to call SetProcessDpiAwareness on Windows
before tkinter.Tk() is called for the htest. Apparently, 'root.destroy()'
undoes a previous 'root = Tk()'. Since IDLE unittests always destroy roots,
a unittest before an htest does not require anything more to work right.
Since part of the purpose of human-viewed tests is to determine that
widgets look right, it is important that they look the same for testing
as when running IDLE.
(cherry picked from commit 3c8043d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>