Home Original page

bpo-34002: Minor efficiency and clarity improvements in email package. by selik · Pull Request #7999 · python/cpython

added 2 commits

June 28, 2018 12:36
Comparing ``len(a) > ``len(a - b)`` is essentially looking for an
intersection between the two sets. If set ``b`` does not intersect ``a``
then ``len(a - b)`` will be equal to ``len(a)``. This logic is more
clearly expressed as ``a & b``.
Copying the list, then repeatedly popping the first element was
unnecessarily slow. I also cleaned up a couple other inefficiencies.
There's no need to unpack a tuple, then re-pack and append it. The list
can be created with the first element instead of empty. Secondly, the
``endswith`` method returns a bool, so there's no need for an if-
statement to set ``encoding`` to True or False.

serhiy-storchaka

@selik 

``a.intersection(b)`` method is more clear of purpose than ``not
a.isdisjoint(b)`` and avoids an unnecessary set construction that ``a &
set(b)`` performs.

@selik selik changed the title Minor efficiency and clarity improvements bpo-34002: minor efficiency and clarity improvements in email package

Jun 29, 2018

rhettinger

serhiy-storchaka

@selik 

While it reads slightly worse, the isdisjoint method will stop when it
finds a counterexample and returns a bool, rather than looping over the
entire iterable and constructing a new set.

@maxking

@maxking maxking changed the title bpo-34002: minor efficiency and clarity improvements in email package bpo-34002: Minor efficiency and clarity improvements in email package.

Sep 20, 2019