[3.7] bpo-25862: Fix several bugs in the _io module. (GH-8026) by miss-islington · Pull Request #8028 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
miss-islington merged 1 commit intopython:3.7from
Jun 30, 2018Merged
[3.7] bpo-25862: Fix several bugs in the _io module. (GH-8026)#8028
miss-islington merged 1 commit intopython:3.7from
[3.7] bpo-25862: Fix several bugs in the _io module. (GH-8026)#8028
miss-islington merged 1 commit intopython:3.7from
Conversation
Copy link Copy Markdown
Contributor
They can be exposed when some C API calls fail due to lack of
memory.
- Failed Py_BuildValue() could cause an assertion error in the
following TextIOWrapper.tell(). - input_chunk could be decrefed twice in TextIOWrapper.seek()
after failed Py_BuildValue(). - initvalue could leak in StringIO.getstate() after failed
PyDict_Copy().
(cherry picked from commit fdb5a50)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com
They can be exposed when some C API calls fail due to lack of memory. * Failed Py_BuildValue() could cause an assertion error in the following TextIOWrapper.tell(). * input_chunk could be decrefed twice in TextIOWrapper.seek() after failed Py_BuildValue(). * initvalue could leak in StringIO.__getstate__() after failed PyDict_Copy(). (cherry picked from commit fdb5a50) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
bedevere-bot
mentioned this pull request
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Jun 30, 2018
miss-islington commented
Jun 30, 2018@serhiy-storchaka: Backport status check is done, and it's a success ✅ .
1 similar comment
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Jun 30, 2018
miss-islington commented
Jun 30, 2018@serhiy-storchaka: Backport status check is done, and it's a success ✅ .
serhiy-storchaka approved these changes Jun 30, 2018
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
miss-islington
merged commit
dedb28e
into
python:3.7
bedevere-bot
removed
the
awaiting merge
label
miss-islington
deleted the
backport-fdb5a50-3.7
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment