[3.7] bpo-32942: Fix environment dependent test_script_helper (GH-8034) by miss-islington · Pull Request #8087 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
miss-islington merged 1 commit intopython:3.7from
Jul 4, 2018Merged
Conversation
Copy link Copy Markdown
Contributor
Result of function interpreter_requires_environment() depends on os.environ.
This was not covered by the tests, leading to fail when PYTHONHOME was set.
(cherry picked from commit a390cb6)
Co-authored-by: Lorenz Mende Lorenz.mende@gmail.com
Result of function interpreter_requires_environment() depends on os.environ. This was not covered by the tests, leading to fail when PYTHONHOME was set. (cherry picked from commit a390cb6) Co-authored-by: Lorenz Mende <Lorenz.mende@gmail.com>
bedevere-bot
mentioned this pull request
bedevere-bot
added
the
skip news
label
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
vstinner approved these changes Jul 4, 2018
Copy link Copy Markdown
Member
vstinner
left a comment
vstinner
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good bot 🤖!
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Jul 4, 2018
miss-islington commented
Jul 4, 2018@LorenzMende and @vstinner: Backport status check is done, and it's a success ✅ .
miss-islington
merged commit
6b3ff35
into
python:3.7
bedevere-bot
removed
the
awaiting merge
label
miss-islington
deleted the
backport-a390cb6-3.7
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment