Home Original page

bpo-34123: Fix missed documentation update for dict.popitem(). by rhettinger · Pull Request #8292 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@rhettinger

Copy link Copy Markdown

Contributor

@rhettinger rhettinger commented

Jul 16, 2018

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just wondering whether it would be helpful to add a "version changed in" blurb too so readers know that relying on LIFO creates a version dependence.

@rhettinger rhettinger merged commit 01b7d58 into python:master

Jul 17, 2018

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link Copy Markdown

GH-8307 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 17, 2018 
…nGH-8292)

(cherry picked from commit 01b7d58)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>

@rhettinger rhettinger deleted the dict-lifo-popitem branch

July 17, 2018 08:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tim-one tim-one tim-one left review comments

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhettinger @miss-islington @bedevere-bot @tim-one @the-knights-who-say-ni